Add parameter to prevent model from being saved to registry in get#53
Merged
JulianVennen merged 2 commits intomasterfrom Mar 27, 2026
Merged
Add parameter to prevent model from being saved to registry in get#53JulianVennen merged 2 commits intomasterfrom
JulianVennen merged 2 commits intomasterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds an option to GenericModel::get() to optionally avoid persisting fetched models into the ModelRegistry, and introduces test coverage for the new registry behavior.
Changes:
- Extend
GenericModel::get()with a new$saveToRegistryparameter and adjust registry lookup behavior when$updateis true. - Add a new PHPUnit test validating registry save/refresh behavior, including the new “don’t save” mode.
- Enable registry usage in the test setup to exercise registry-related behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/GenericModel.php |
Adds $saveToRegistry parameter and updates registry interaction logic in get() |
test/tests/TestDriverTest.php |
Enables registry in setup and adds testGetWithRegistry() to validate registry semantics |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
matthi4s
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.